Skip to content

tests: runtime_shell: Don't use Golang compiler on RISC-V 64bit Linux#11577

Open
cosmo0920 wants to merge 1 commit intomasterfrom
cosmo0920-dont-use-golang-compiler-on-riscv64-linux-in-test
Open

tests: runtime_shell: Don't use Golang compiler on RISC-V 64bit Linux#11577
cosmo0920 wants to merge 1 commit intomasterfrom
cosmo0920-dont-use-golang-compiler-on-riscv64-linux-in-test

Conversation

@cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Mar 18, 2026

Currently, riscv64 architecture is not assumed to test Golang plugin in our CI tasks.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Tests
    • Updated test configurations to conditionally skip certain proxy log tests on RISC-V 64-bit Linux systems while maintaining existing behavior on other Linux architectures.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920 cosmo0920 requested a review from edsiper as a code owner March 18, 2026 02:03
@cosmo0920 cosmo0920 added this to the Fluent Bit v5.0 milestone Mar 18, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

📝 Walkthrough

Walkthrough

The CMakeLists.txt for runtime shell tests now conditionally includes the proxy_logs_expect.sh script only on Linux builds for non-RISC-V 64-bit architectures, emitting a status message for RISC-V 64-bit configurations instead.

Changes

Cohort / File(s) Summary
Test Configuration
tests/runtime_shell/CMakeLists.txt
Added conditional logic to skip proxy_logs_expect.sh test script on RISC-V 64-bit Linux builds while emitting a status message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Suggested labels

docs-required

Suggested reviewers

  • niedbalski

Poem

🐰 Hops through the build with care,
RISC-V skips the test with flair,
Architecture-aware, we run the race,
Each processor in its proper place!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately summarizes the main change: excluding a Golang-based test script (proxy_logs_expect.sh) on RISC-V 64-bit Linux architecture.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cosmo0920-dont-use-golang-compiler-on-riscv64-linux-in-test
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cosmo0920 cosmo0920 changed the title tests: runtime_shell: Don't use Golang compiler on RISC-V 64 Linux tests: runtime_shell: Don't use Golang compiler on RISC-V 64bit Linux Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant