Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated connection label length and host formatting; compose_user_friendly_remote_host now brackets IPv6 literals and unifies TCP/UDP formatting; net_address_ip_str recognizes IPv4-mapped IPv6 addresses and emits native IPv4 text; minor syslog plugin log message wording adjusted. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Example config file: [SERVICE]
flush 1
daemon Off
log_level info
parsers_file ../conf/parsers.conf
[INPUT]
name syslog
tag syslog
listen ::
mode udp
parser syslog-rfc5424
source_address_key source
[OUTPUT]
name stdout
match * |
Contributor
Author
|
Debug log output: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddc3721b37
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@include/fluent-bit/flb_connection.h`:
- Around line 37-46: The macro FLB_CONNECTION_MAX_LABEL_LENGTH is miscalculated
for IPv6 brackets (should be 9 not 8); update the define
FLB_CONNECTION_MAX_LABEL_LENGTH to 9 and correct the accompanying comment, and
then verify usages in compose_user_friendly_remote_host and the buffer
connection->user_friendly_remote_host to ensure their allocated size accounts
for the updated label overhead plus hostname/port and NUL terminator (increase
buffer allocation if needed) so snprintf bounds remain correct and the formatted
string cannot be truncated into a malformed value.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 243328ff-3724-4484-8152-788c8cba2acc
📒 Files selected for processing (3)
include/fluent-bit/flb_connection.hsrc/flb_connection.csrc/flb_network.c
Fixes: fluent#11558 Signed-off-by: Per von Zweigbergk <pvz@pvz.pp.se>
Fixes: fluent#11560 Signed-off-by: Per von Zweigbergk <pvz@pvz.pp.se>
Contributor
Author
|
@coderabbitai review |
|
🧠 Learnings used✅ Actions performedReview triggered.
|
Contributor
Author
|
Valgrind output: |
…ent#11559) Signed-off-by: Per von Zweigbergk <pvz@pvz.pp.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #11560 and fixes #11558 and fixes #11559
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit