docs: outputs: http: general updates and fixes, added missing config parameters#2434
docs: outputs: http: general updates and fixes, added missing config parameters#2434eschabell wants to merge 1 commit intofluent:masterfrom
Conversation
…parameters - Add 16 missing oauth2.* parameters sourced from plugin config_map - Fix json_date_format default: "double" -> _none_ - Fix uri default: "/" -> _none_ - Fix config param table column alignment - Remove redundant intro sentence - Fix trailing space in aws_service description - Fix classic config example case issues - Use "OAuth 2.0" per style guide in all oauth2 parameter descriptions - Spell out JWT (JSON Web Token) on first use per style guide Applies to fluent#2412 Signed-off-by: Eric D. Schabell <eric@schabell.org>
📝 WalkthroughWalkthroughDocumentation update to HTTP output configuration guide with table formatting adjustments, configuration key naming refinements (URI/Uri, header_tag/Header_tag), and expanded OAuth 2.0 parameter documentation. No functional code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pipeline/outputs/http.md (1)
150-152: Optional: fully normalizeURIcasing across this page.These updates switch to
Uri, but the earlier classic snippet still usesURIat Line 113. Consider normalizing that remaining instance for full intra-page consistency.Based on learnings: classic
fluent-bit.confexamples intentionally use Title_Case plugin-specific keys.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/outputs/http.md` around lines 150 - 152, Update the remaining classic fluent-bit.conf snippet to use the same Title_Case key name "Uri" (replace the lone "URI" instance) so the page consistently uses "Uri" across both the newer and classic examples; ensure you only change the casing of the key (retain plugin-specific Title_Case convention and surrounding config text) in the snippet that currently shows "URI".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pipeline/outputs/http.md`:
- Around line 150-152: Update the remaining classic fluent-bit.conf snippet to
use the same Title_Case key name "Uri" (replace the lone "URI" instance) so the
page consistently uses "Uri" across both the newer and classic examples; ensure
you only change the casing of the key (retain plugin-specific Title_Case
convention and surrounding config text) in the snippet that currently shows
"URI".
|
@cosmo0920 and @patrick-stephens ready for review! |
Applies to #2412
Summary by CodeRabbit