Skip to content

revert: removing incorrectly merged #349#2430

Merged
eschabell merged 1 commit intomasterfrom
revert_349
Mar 16, 2026
Merged

revert: removing incorrectly merged #349#2430
eschabell merged 1 commit intomasterfrom
revert_349

Conversation

@patrick-stephens
Copy link
Contributor

@patrick-stephens patrick-stephens commented Mar 16, 2026

Reverts #349 to hopefully prevent comments like this: fluent/fluent-bit#2399 (comment)

The PR was incorrectly merged by me (apologies!) without the necessary implementation changes. Cannot auto-revert due to all the other refactoring since then so manually reverted.

Summary by CodeRabbit

  • Documentation
    • Removed configuration example documentation, code samples, and related explanatory content from the rewrite_tag filter documentation
    • Updated the monitoring section with newly documented information about additional metrics being tracked and clarified detailed explanations of how internal emitter configuration and naming options directly impact metric collection and reporting behavior

Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ccf8a631-f0ff-4d50-b8dd-87fabacd24f3

📥 Commits

Reviewing files that changed from the base of the PR and between 05b4b45 and 6684612.

📒 Files selected for processing (1)
  • pipeline/filters/rewrite-tag.md
💤 Files with no reviewable changes (1)
  • pipeline/filters/rewrite-tag.md

📝 Walkthrough

Walkthrough

This PR updates the rewrite-tag filter documentation by removing a configuration example demonstrating multiple rules and revising the Monitoring section to clarify how metrics are emitted and introduce documentation for the emit_records metric.

Changes

Cohort / File(s) Summary
Documentation Updates
pipeline/filters/rewrite-tag.md
Removed "Configuration example with multiple rules" section (YAML and config examples). Updated Monitoring section to clarify record emission through pipeline, document emit_records metric, and explain emitter_name behavior with metrics.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

5.0

Suggested reviewers

  • cosmo0920

Poem

🐰 A cleaner path through documentation land,
Removed the clutter, made it grand,
Monitoring shines with metrics new,
The rewrite-tag guide, refreshed and true! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly indicates this is a revert of pull request #349, which aligns with the PR objectives stating the author is reverting an incorrectly merged PR and manually undoing documentation changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert_349
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable sequence diagrams in the walkthrough.

Disable the reviews.sequence_diagrams setting to disable sequence diagrams in the walkthrough.

@eschabell eschabell merged commit 9691fb1 into master Mar 16, 2026
8 checks passed
@eschabell eschabell deleted the revert_349 branch March 16, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants