V3 #120
V3 #120
Conversation
| context.data.request.command.toLowerCase() : ''; | ||
| const { relevanceProvider = getLevenshteinRelevance } = params; | ||
| return (context: Context) => { | ||
| const commandLower = context.data.request.command |
There was a problem hiding this comment.
This code duplicates at least 3 times, maybe it's better to implement function for this operation
| headers: { | ||
| 'Authorization': `OAuth ${this._oAuthToken}`, | ||
| Authorization: `OAuth ${this._oAuthToken}`, | ||
| 'Content-type': 'application/json', |
There was a problem hiding this comment.
It should be a 'Content-Type' header with capital T
| @@ -0,0 +1,78 @@ | |||
| declare module 'alice-renderer' { | |||
There was a problem hiding this comment.
Declared Response interface is not-compatible with ApiResponseBody as a result tests won't work with the new reply.
I've tried to fix this issue in forked repo by declaring API as ambient module and importing API types here, but I can't find a good solution how to ship this types with NPM package. It seems that *.d.ts files added to dist folder won't be resolved by the typescript compiler if package is used as dependency.
shining-mind
left a comment
shining-mind
left a comment
There was a problem hiding this comment.
We need to find a way how to ship alice-renderer types declaration with the package, so projects which are written in TypeScript could compile.
No description provided.