refactor: simplify standard vs flashblocks switch#419
Closed
Conversation
akundaz
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
Collaborator
|
can we remove the standard builder here? |
akundaz
force-pushed
the
ash-lqtmwknrvqvq
branch
from
649a03c to
929c2f6
Compare
akundaz
force-pushed
the
ash-lqtmwknrvqvq
branch
from
929c2f6 to
1f433d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuilderConfigtype not generic and puts the flashblocks config in their as an optionalPayloadBuildertrait and implementPayloadServiceBuilderon an enum with variants for standard and flashblocks