Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a crate with the attestation generation, verification, and measurement handling logic refactored out of
attested-tls-proxy.We may not need the
dcapmodule - as this can be handled internally byra-tls. But because thedcapstuff is also internally used by the azure attestation, we need to keep it in for now.Paired PR
This pairs with flashbots/attested-tls-proxy#150 which uses this branch for
attestationcrate, to avoid duplicating the code.Eventually we will probably not need that repo anymore, but as long as it is still being used by Buildernet we have to maintain it and it makes sense for the attestation code to be in just one place.
Github workflow for testing, clippy and formatting
I added a workflow for testing. I think this is an opinionated way of doing things, and maybe doesn't belong in this PR. But i wanted to see it pass before putting this up for review. So we can always switch to another CI script in a followup afterwards.
This also adds a
rust-toolchain.tomlusing nightly which i needed locally to get the formatting correct for CI.Crypto provider for rustls
When used as a library we have
default-features = falsefor tokio-rustls, to allow the caller to choose crypto provider. As a dev-dependency we use the default provider for testing.