Skip to content

chore. Add target _blank to links#39

Closed
pangolp wants to merge 1 commit intoflarum:masterfrom
pangolp:markdown
Closed

chore. Add target _blank to links#39
pangolp wants to merge 1 commit intoflarum:masterfrom
pangolp:markdown

Conversation

@pangolp
Copy link

@pangolp pangolp commented Oct 8, 2025

Changes proposed in this pull request:

What I want to achieve with this pull request is that the links can have the corresponding HTML tag, so that they can be opened in another tab.

Reviewers should focus on:

This is my first time working with the community, so I may need some guidance, but if necessary, I'm willing to make any necessary changes to get the code working and merged.

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@pangolp pangolp closed this Oct 8, 2025
@pangolp
Copy link
Author

pangolp commented Oct 8, 2025

I'm closing this thread because I actually made the change without being able to test the project. When I tested it locally, I noticed that when I installed the extension using Composer, it was on the 2.x branch, possibly because the changes mentioned in this PR are incompatible and are throwing errors. So, I'm going to try to reactivate the previous branch from PR 38, and if not, I'll have to create another request with the proposal. My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant