This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Conversation
commit: |
dario-piotrowicz
approved these changes
Jan 15, 2025
Contributor
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Looks good to me 🙂 , I just left some minor comments
jamesopstad
force-pushed
the
james/websocket-support
branch
from
b25120e to
192f4e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #20
This adds support for WebSockets. There are some intricacies still to figure out around gracefully handling connection closing but, unless there is a quick solution, I think that could be done in a follow up PR. For now, there are sometime workerd errors when a connection is closed.