Skip to content

bugfix/tests-and-sales-tax-qs #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fivetran-joemarkiewicz merged 5 commits into from
Jan 14, 2026
Merged

bugfix/tests-and-sales-tax-qs #192

fivetran-joemarkiewicz merged 5 commits into from
Jan 14, 2026

Conversation

@fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Jan 12, 2026 •
edited
Loading

PR Overview

Package version introduced in this PR:

  • v1.3.0

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Fixes a test config in the stg_quickbooks.yml file to correctly be configured as tests
  • For Quickstart only, disables the sales tax components by default.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • See internal ticket for more details
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

fivetran-savage and others added 2 commits January 12, 2026 13:17
@fivetran-savage @fivetran-joemarkiewicz
documentation/single_accounts_payable_decisionlog (#190)
7164361 
* documentation/single_accounts_payable_decisionlog

* add_changelog_entry

* update_decisionlog_and_readme

* Apply suggestions from code review

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

---------

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
@fivetran-joemarkiewicz
changelog update
f5b8cf8
@fivetran-joemarkiewicz fivetran-joemarkiewicz mentioned this pull request Jan 12, 2026
Closed
4 tasks
@fivetran-joemarkiewicz fivetran-joemarkiewicz added the docs:ready Triggers the docs generator workflow. label Jan 12, 2026
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review January 12, 2026 21:11
fivetran-avinash
fivetran-avinash approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz Approved with two suggestions!

@fivetran-joemarkiewicz @fivetran-avinash
Apply suggestions from code review
43b26a2 
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 3ecb00f into main Jan 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fivetran-avinash fivetran-avinash fivetran-avinash approved these changes

Assignees

@fivetran-joemarkiewicz fivetran-joemarkiewicz

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fivetran-joemarkiewicz @fivetran-avinash @fivetran-savage