Skip to content

Conversation

@fivetran-joemarkiewicz
Copy link
Contributor

PR Overview

Package version introduced in this PR:

  • v1.2.0

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Clarifies the amount fields in the netsuite2__transaction_details and netsuite__transaction_details end models to specify the sign flip.
  • In addition to the above, adds three new fields to represent the raw state of the amount fields for easier mapping to the raw data.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
      • See internal ticket for details
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-joemarkiewicz fivetran-joemarkiewicz self-assigned this Nov 5, 2025
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review November 5, 2025 22:00
@fivetran-joemarkiewicz fivetran-joemarkiewicz added the docs:ready Triggers the docs generator workflow. label Nov 5, 2025
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 1dc9b17 into main Nov 6, 2025
10 checks passed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the feature/non-converted-fields branch November 6, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Clarify transaction_detail documentation and include non converted amount field.

2 participants