-
Notifications
You must be signed in to change notification settings - Fork 451
Make it possible to override the zeroAt value #5733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3363bec to
9faf5e8
Compare
locales/en-US/app.ftl
Outdated
| MarkerContextMenu--end-selection-at-marker-end = | ||
| End selection at marker’s <strong>end</strong> | ||
| MarkerContextMenu--override-zero-at-marker-start = | ||
| Override zero at marker’s start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this concept is going to be clear to localizers. Is "zero" just the start?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. It comes from "getZeroAt" name, but it's not obvious.
Other options I can think of are the following:
- Override the start of the timeline with marker's start
- Set the start of the timeline with marker's start
- Override the timeline origin with marker's start
- Set the timeline origin with marker's start
- Start the timeline from marker's start
And the following for the menu button:
- Starts at 100ms
- Starts from 100ms
- Origin at 100ms
- Origin overridden to 100ms
Can I have your opinion?
If there are better labels, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for @canova and folks who understand the project — and target audience — better than me.
Personally, I would go with something like:
Align the timeline start with the marker start(orSet… to).- Starting point moved to 100ms
9faf5e8 to
c39e700
Compare
|
Updated the label, added dedicate icon, and rebased |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5733 +/- ##
==========================================
+ Coverage 85.67% 85.69% +0.01%
==========================================
Files 315 315
Lines 31110 31141 +31
Branches 8472 8566 +94
==========================================
+ Hits 26654 26685 +31
Misses 4026 4026
Partials 430 430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c39e700 to
1ca1a1c
Compare
Production | Deploy preview
Fixed #5730
This adds "Align the timeline start with the marker start" menu item to markers, which overrides the "zeroAt" value.
When overridden the menu buttons at the top of the page gets "Starting point moved to (timestamp)" button.
Clicking it resets the override.
Also this supports negative timestamp.
The timeline looks line the following when overridden.