Skip to content

Conversation

@arai-a
Copy link
Contributor

@arai-a arai-a commented Dec 23, 2025

Production | Deploy preview

Fixed #5730

This adds "Align the timeline start with the marker start" menu item to markers, which overrides the "zeroAt" value.

start-menu

When overridden the menu buttons at the top of the page gets "Starting point moved to (timestamp)" button.
Clicking it resets the override.

start-button

Also this supports negative timestamp.
The timeline looks line the following when overridden.

timeline

MarkerContextMenu--end-selection-at-marker-end =
End selection at marker’s <strong>end</strong>
MarkerContextMenu--override-zero-at-marker-start =
Override zero at marker’s start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this concept is going to be clear to localizers. Is "zero" just the start?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. It comes from "getZeroAt" name, but it's not obvious.

Other options I can think of are the following:

  • Override the start of the timeline with marker's start
  • Set the start of the timeline with marker's start
  • Override the timeline origin with marker's start
  • Set the timeline origin with marker's start
  • Start the timeline from marker's start

And the following for the menu button:

  • Starts at 100ms
  • Starts from 100ms
  • Origin at 100ms
  • Origin overridden to 100ms

Can I have your opinion?
If there are better labels, let me know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @canova and folks who understand the project — and target audience — better than me.

Personally, I would go with something like:

  • Align the timeline start with the marker start(or Set… to).
  • Starting point moved to 100ms

@arai-a
Copy link
Contributor Author

arai-a commented Jan 10, 2026

Updated the label, added dedicate icon, and rebased

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.69%. Comparing base (0dd124f) to head (1ca1a1c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5733      +/-   ##
==========================================
+ Coverage   85.67%   85.69%   +0.01%     
==========================================
  Files         315      315              
  Lines       31110    31141      +31     
  Branches     8472     8566      +94     
==========================================
+ Hits        26654    26685      +31     
  Misses       4026     4026              
  Partials      430      430              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show the Start time relative to "Navigation::Start" in the Marker Table

2 participants