Make sure to fetch the full git history for l10n-sync job in CI #5667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5667 +/- ##
==========================================
- Coverage 85.63% 85.58% -0.06%
==========================================
Files 312 312
Lines 30867 30918 +51
Branches 8488 8532 +44
==========================================
+ Hits 26434 26462 +28
- Misses 4009 4026 +17
- Partials 424 430 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
The test CI run that I triggered in this PR is successful: https://github.com/firefox-devtools/profiler/actions/runs/19167335496/job/54791100052 I'm removing that commit so we can land this. |
canova
changed the title
mstange
approved these changes
Nov 7, 2025
Merged
canova
added a commit
that referenced
this pull request
Nov 12, 2025
Changes: [Nazım Can Altınova] Use getEmptySourceTable instead of constructing the table manually (#5641) [Florian Quèze] Source view for marker stacks (#5633) [Nazım Can Altınova] Add fallback to funcTable.lineNumber when computing line timings (#5644) [Florian Quèze] Show the marker keys instead of the labels in marker tooltips when alt is pressed. (#5625) [Francesco Lodolo] Add GitHub workflow to check Fluent reference files (#5647) [Nazım Can Altınova] Switch from Gitpod to GitHub Codespaces (#5653) [Nazım Can Altınova] Migrate from CircleCI to GitHub Actions (#5654) [Nazım Can Altınova] Run the CI in the production branch and on every pull request (#5661) [Nazım Can Altınova] Convert l10n-sync.js from Flow comment types to JSDoc comments for Typescript (#5659) [Florian Quèze] Display correct unit in Stack Chart tooltips for size profiles. (#5658) [Florian Quèze] Hide track management UI in single track profiles. (#5656) [Florian Quèze] Rename hiddenTrackCount to trackCount. (#5665) [Florian Quèze] Cleanup the profile info panel for size profiles (show file size and name, hide empty sections). (#5657) [Markus Stange] Use valibot for symbolication API response validation (#5666) [Nazım Can Altınova] Make sure to fetch the full git history for l10n-sync job in CI (#5667) [Nazım Can Altınova] Do not switch to call tree when clicking the activity graph while on sample based panels (#5672) And thanks to our localizers: be: Mikalai Udodau de: Michael Köhler el: Jim Spentzos en-GB: Ian Neal es-CL: ravmn fr: Théo Chevalier fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: berry, Valery Ledovskoy sv-SE: Andreas Pettersson tr: Grk zh-CN: Olvcpr423, wxie zh-TW: Pin-guang Chen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the l10n-sync job has failed in CI this morning. I believe this is because of a difference between CircleCI and GitHub Actions
actions/checkout@v5action. It looks like the GitHub action does a shallow clone since v4, but CircleCI was doing a full clone. We need the full history to be able to do some git operations inside the l10n-sync.js script.fetch-depth: 0makes sure to fetch the full history for this task.