Add foreign key from FormSubmission.template_id to Template.id#195
Open
sonikagutha wants to merge 1 commit intofireform-core:mainfrom
Open
Add foreign key from FormSubmission.template_id to Template.id#195sonikagutha wants to merge 1 commit intofireform-core:mainfrom
sonikagutha wants to merge 1 commit intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a database-level foreign key so
FormSubmission.template_idmust reference an existingTemplate.id, enforcing referential integrity and preventing orphan submissions.Changes
(
api/db/models.py) : DeclaredFormSubmission.template_idwithField(foreign_key="template.id")instead of a plainint.Motivation
Previously,
template_idhad no FK constraint. The database could accept submissions pointing to non-existent or deleted templates. This PR ensures every submission references a valid template.Testing
New databases created via
python -m api.db.init_dbinclude the constraint.Inserting a
FormSubmissionwith an invalidtemplate_idis rejected by the DB.Notes
Existing databases: Unchanged unless re-initialized. To apply the FK on an existing DB, you would need to recreate the schema or run a migration (e.g. new DB + export/import, or a migration script).
No API or request/response changes; behavior is backward compatible for valid data.
Fixes #194