Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #189
Fix: Implement secure temporary file handling and cleanup in
main.py📝 Description
This PR addresses an issue where
main.pyleaves a hardcoded intermediate PDF (temp_outfile.pdf) on the disk after execution.Previously, if multiple requests were processed simultaneously, the hardcoded filename could cause race conditions. Furthermore, if the script crashed during execution, the temporary file was never deleted, leading to directory clutter and potential security risks by leaving template structures on the disk.
🛠️ Changes Made
temp_outfile.pdfstring with Python's built-intempfile.mkstemp()to generate secure, collision-proof temporary file paths dynamically.try...finallyblock.os.remove()to thefinallyblock to guarantee the OS purges the temporary file immediately after execution, regardless of whether the script succeeds or throws an exception.🧪 How to Test
python src/main.py(ormake execif using Docker).temp_outfile.pdf(or any other randomized.pdftemp files) are completely removed.