fix: add missing Union import in main.py#188
Open
devanmolx wants to merge 1 commit intofireform-core:mainfrom
Open
fix: add missing Union import in main.py#188devanmolx wants to merge 1 commit intofireform-core:mainfrom
devanmolx wants to merge 1 commit intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187
Problem
Unionis used as a type hint in run_pdf_fill_process() but wasnever imported, causing an immediate NameError on startup:
NameError: name 'Union' is not defined
Changes
Added to src/main.py:
from typing import UnionHow to verify
docker compose up -ddocker exec -it fireform-app bashpython src/main.pyType of change
Checklist