FIX: Runtime crash in textToJSON.add_response_to_json #183
Open
Aryama-srivastav wants to merge 3 commits intofireform-core:mainfrom
Open
FIX: Runtime crash in textToJSON.add_response_to_json #183Aryama-srivastav wants to merge 3 commits intofireform-core:mainfrom
Aryama-srivastav wants to merge 3 commits intofireform-core:mainfrom
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a runtime crash in textToJSON.add_response_to_json when the same field is processed more than once.
Previously, the first value for a field was stored as a scalar, but on repeated occurrences the code attempted to call .append(...) on that scalar, raising:
AttributeError: 'str' object has no attribute 'append'.
This change makes duplicate-field handling type-safe:
Fixes #182
Type of change
How Has This Been Tested?
Test A (duplicate field path):
python -c "import sys; sys.path.insert(0,'src'); from backend import textToJSON; obj=textToJSON.new(textToJSON); obj._textToJSON__json={}; obj.add_response_to_json('Employee name','John'); obj.add_response_to_json('Employee name','Jane'); print(obj._textToJSON__json)"
{'Employee name': ['John', 'Jane']}
Verified no crash.
Test B (single field behavior):
python -c "import sys; sys.path.insert(0,'src'); from backend import textToJSON; obj=textToJSON.new(textToJSON); obj._textToJSON__json={}; obj.add_response_to_json('Department','Operations'); print(obj._textToJSON__json)"
{'Department': 'Operations'}
Test Configuration:
Checklist: