#179- sanitize path outputs of template created and filled#180
Open
Cubix33 wants to merge 1 commit intofireform-core:mainfrom
Open
#179- sanitize path outputs of template created and filled#180Cubix33 wants to merge 1 commit intofireform-core:mainfrom
Cubix33 wants to merge 1 commit intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179
🚀 Description
Fixes path traversal vulnerabilities and secures temporary file storage. Replaced insecure string slicing with
pathlibfor safe filename extraction, and implementedtempfileto securely manage intermediate templates outside the project root.🛠️ Changes Proposed
src/file_manipulator.py: Switched totempfile.mkstemp()to securely generate_template.pdfin the OS temp directory.src/filler.py: Replaced[:-4]withpathlib.Path().stemand added auto-routing for final PDFs into an isolatedoutputs/directory.✅ PR Checklist
outputs/directory dynamically created if missing.