Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #168
📝 Description
This PR refactors the PDF annotation sorting logic in
src/filler.py. It replaces the strict coordinate-based sort with a Y-Cluster Spatial Sorting algorithm. This ensures that form fields on the same visual line (like "First Name" and "Last Name") are grouped correctly into "rows" before being sorted left-to-right, even if their Y-coordinates differ by a few pixels.🛠️ Technical Changes
src/filler.pythat groups PDF widgets within a 10-pixel Y-axis tolerance.Rect[1]).Rect[0]).💡 Rationale
Strict coordinate sorting often fails on professionally designed, multi-column forms or tables where fields are meant to be read left-to-right but may have slight misalignments in the underlying PDF code. This change allows FireForm to handle dense, complex layouts (medical, legal, and government forms) with much higher accuracy.
🧪 Quality Check