FIX : Improves Ollama request robustness in textToJSON.main_loop#171
Open
Aryama-srivastav wants to merge 2 commits intofireform-core:mainfrom
Open
FIX : Improves Ollama request robustness in textToJSON.main_loop#171Aryama-srivastav wants to merge 2 commits intofireform-core:mainfrom
Aryama-srivastav wants to merge 2 commits intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves Ollama request robustness in textToJSON.main_loop by handling request failures explicitly instead of letting raw networking exceptions propagate.
What changed
Why
Previously, when OLLAMA_HOST was unreachable, the code surfaced raw requests/urllib3 stack traces. With this change, the backend now raises a clear, controlled RuntimeError with actionable context (target Ollama URL and failure reason), improving reliability and debugging experience.
Fixes #169
Type of change
How Has This Been Tested?
Set:
PYTHONPATH=src
OLLAMA_HOST=http://127.0.0.1:18080 (unreachable host)
Run:
python -c "from backend import textToJSON; try: textToJSON('employee is John', ['Employee name']); except Exception as e: print(type(e).name); print(e)"
Result:
RuntimeError
Message starts with Failed to reach Ollama at http://127.0.0.1:18080/api/generate: ...
Verified that failure is now raised from application code as a controlled exception, rather than uncaught raw requests.exceptions.ConnectionError.
Test Configuration:
Checklist: