FIX: Make ollama smoke test optional during pytest collection#166
Open
Aryama-srivastav wants to merge 1 commit intofireform-core:mainfrom
Open
FIX: Make ollama smoke test optional during pytest collection#166Aryama-srivastav wants to merge 1 commit intofireform-core:mainfrom
Aryama-srivastav wants to merge 1 commit intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes test collection failures in clean environments where the optional ollama Python package is not installed.
Previously, src/test/test_model.py imported ollama at module import time, which caused pytest collection to fail with ModuleNotFoundError and prevented the rest of the suite from running. The test has been updated to use pytest-compatible optional dependency handling so environments without ollama skip this integration smoke test instead of failing collection.
Fixes #163
Type of change
How Has This Been Tested?
-Ran:
python -m pytest -q src/test/test_model.py
-Result:
1 skipped in 0.11s when ollama is not installed, confirming collection no longer errors and behavior is now optional.
Test Configuration:
Checklist: