fix(js): initialize all plugins before lookup in registry

[Ehesp]

registry.lookupAction('/flow/foo') can return undefined even when registry.listActions() includes that key.

parseRegistryKey() only sets pluginName when the key has 4+ segments (e.g. /flow/myPlugin/foo).
For 3-segment keys like /flow/orchestrator there is no pluginName.

In lookupAction(), the block that calls initializePlugin(parsedKey.pluginName) and resolvePluginAction() only runs when parsedKey.pluginName is set, so it is skipped for 3-segment keys.

The method then does return (await this.actionsById[key]) || this.parent?.lookupAction(key) without having run initializeAllPlugins(), so plugin-registered actions may not be in actionsById yet.

This PR fixes that by initializing if the key is not via a plugin or a dynamic action.

Workaround for now is to call listActions() before lookupAction.

Checklist (if applicable):

• PR title is following https://www.conventionalcommits.org/en/v1.0.0/
• Tested (manually, unit tested, etc.)
• Docs updated (updated docs or a docs bug required)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the Registry class where lookupAction might fail to find actions registered by plugins if the action key does not explicitly contain a plugin segment. Previously, the conditional plugin initialization logic would skip initialization for such keys, leading to missing actions. The fix ensures that all plugins are proactively initialized in these specific scenarios, guaranteeing that all registered actions are available for lookup and improving the reliability of the action registry.

Highlights

• Registry Action Lookup Fix: Resolved an issue where registry.lookupAction() could fail to find actions registered by plugins when the action key did not explicitly include a plugin name (e.g., 3-segment keys like /flow/foo).
• Plugin Initialization Logic: Modified the lookupAction method in the Registry class to ensure all plugins are initialized if the action key does not specify a plugin name or a dynamic action host, preventing actions from being missed.
• New Test Case: Added a new test case to verify that actions registered by plugins are correctly found by lookupAction, even with 3-segment keys that previously caused issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• js/core/src/registry.ts
  • Added a conditional call to initializeAllPlugins() within lookupAction() to ensure plugins are initialized for keys without a pluginName or dynamicActionHost.
  • Added comments explaining the rationale for the new initialization logic.
• js/core/tests/registry_test.ts
  • Added a new test case to confirm that lookupAction() successfully retrieves an action registered by a plugin using a 3-segment key (e.g., /flow/foo), which previously failed.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug where lookupAction could fail to find actions registered by plugins if the action key is a 3-segment key (e.g., /flow/foo) that doesn't explicitly contain a plugin name. The fix correctly calls initializeAllPlugins in this scenario to ensure all plugin-registered actions are available before the lookup. The change is accompanied by a new unit test that validates the fix. The overall approach is sound. I have one suggestion to improve the robustness of the fix by handling invalid keys more efficiently.