Add a bitrate command line argument to control bitrate of output video #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Note that this is just what worked for my specific use case. It looks like this probably does nothing for 2D video upscaling, but I'm not sure how best to add that. Feel free to close the PR without merging if this isn't the way you want to go about doing this kind of thing :) |
Author
|
Adding a note here that there's also an alternative implementation available on my This version automatically calculates a bitrate for the 3D video if one hasn't been passed in on the command line. I can make a PR with that branch instead, if you prefer that implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for specifying a bit rate for the output video file on the command line (
--bitrate)Potential fix for #19