Code quality improvements #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ C0114: Missing module docstring - Added comprehensive module docstring ✅ C0103: Constant naming - Changed log_format and date_format to LOG_FORMAT and DATE_FORMAT ✅ C0303: Trailing whitespace - Removed trailing whitespace ✅ C0304: Missing final newline - Added final newline ✅ W0718: Broad exception caught - Changed from Exception to requests.RequestException ✅ W1203: f-string in logging - Changed all f-string logging to lazy % formatting ✅ R1710: Inconsistent return statements - Added explicit return None to ask_mullvad ✅ W0621: Redefined outer name - Removed global relay_list and renamed parameters ✅ C0116: Missing function docstring - Added docstring to cli() function ✅ R0913/R0917: Too many arguments - Refactored create() to use **kwargs ✅ W1514: Missing encoding - Added encoding="utf-8" to all open() calls ✅ W1309: f-string without interpolation - Fixed the restart message string Remaining Issue:⚠️ C0103: Module name doesn't conform to snake_case - This is about the filename wg-conf-gen.py using hyphens instead of underscores. This is typically left as-is to maintain backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.