-
Notifications
You must be signed in to change notification settings - Fork 275
fix(swift): Enable wire tests for Swift SDK exhaustive fixture #11791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsklan
wants to merge
11
commits into
main
Choose a base branch
from
jsklan/swift-exh-wire
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix dynamic IR to only include endpoint-level headers (not service-level) - Fix Swift dynamic snippet generator to handle endpoint-level headers - Fix Swift dynamic snippet generator to handle referenced body types correctly - Fix Swift dynamic snippet generator to convert set types to JSONValue expressions - Fix wire test generator to use full type names for enum and union types - Fix wire test generator to handle set types with JSONValue conversion - Fix wire test generator to properly format string vs JSON response types - Add user-specified examples to set<T> endpoints in exhaustive fixture Co-Authored-By: [email protected] <[email protected]>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: [email protected] <[email protected]>
…f dynamic IR Co-Authored-By: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: Request from @jsklan
Link to Devin run
Enables wire tests for the Swift SDK exhaustive fixture by fixing several issues in the dynamic snippet generator and wire test generator.
Changes Made
Swift Dynamic Snippets (
EndpointSnippetGenerator.ts).init(body: ...)Swift Dynamic Snippets (
DynamicTypeLiteralMapper.ts)JSONValue.array([...]))Swift Wire Test Generator (
WireTestFunctionGenerator.ts)Animal.doginstead of.dog) for proper Swift type inferenceTest Definitions
set<T>endpoints in exhaustive fixture to ensure autogenerated examples include request body values (with proper response fields)Testing
fern checkpasses for exhaustive fixtureReview Checklist
DynamicTypeLiteralMapper.tshandles all type cases correctlyisStringResponseType()inWireTestFunctionGenerator.tscorrectly resolves type aliasesEndpointSnippetGenerator.tscorrectly identifies headers fromthis.context.ir.headersUpdates since last revision
DynamicSnippetsConverter.ts) that was filtering service-level headers at the IR level - this was breaking other generators (e.g., PHP SDK)EndpointSnippetGenerator.ts), so it only affects Swift and not other generators