fix(csharp): normalize datetime strings in snippet generator #11737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
fern-support
force-pushed
the
patrick/csharp/datetime-fix
branch
3 times, most recently
from
db746bf to
a5db430
Compare
patrickthornton
commented
Jan 26, 2026
| ); | ||
| } | ||
|
|
||
| [NUnit.Framework.Test] |
Contributor
Author
There was a problem hiding this comment.
here is the relevant test that would have failed before this
fern-support
force-pushed
the
patrick/csharp/datetime-fix
branch
from
6b76e19 to
5ba7658
Compare
| set: optional<set<string>> | ||
| map: optional<map<integer, string>> | ||
| bigint: optional<bigint> | ||
| datetimeinstring: optional<string> |
Collaborator
There was a problem hiding this comment.
change it to datetime_in_string
fern-support
approved these changes
Jan 26, 2026
| set: optional<set<string>> | ||
| map: optional<map<integer, string>> | ||
| bigint: optional<bigint> | ||
| datetimeinstring: optional<string> |
Collaborator
There was a problem hiding this comment.
change it to datetime_in_string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Occasionally, strings that were in fact DateTimes would be normalized by the wire test generator, but not in the snippet generator, leading to mismatches and failed wire tests; this normalizes those DateTimes in the snippet generator.
Changes Made
Just to csharp-model.