Skip to content

functions: avoid using array indices to get value form string #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlfredWJ wants to merge 3 commits into
base: main
Choose a base branch
from
Open

functions: avoid using array indices to get value form string #498

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1af271
functions: avoid using array indices to get value form string
AlfredWJ Jun 25, 2025
5e65647
Update etc/rc.d/init.d/functions
AlfredWJ Jun 26, 2025
8ca0939
Update etc/rc.d/init.d/functions
AlfredWJ Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions etc/rc.d/init.d/functions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,7 @@ __kill_pids_term_kill_checkpids() {

for pid in $pids ; do
[ ! -e "/proc/$pid" ] && continue
read -r line < "/proc/$pid/stat" 2> /dev/null

stat=($line)
stime=${stat[21]}
stime=$(cut -d" " -f22 /proc/$pid/stat 2> /dev/null)

[ -n "$stime" ] && [ "$base_stime" -lt "$stime" ] && continue
remaining="$remaining$pid "
Expand All @@ -141,8 +138,7 @@ __kill_pids_term_kill() {

# We can't initialize stat & base_stime on the same line where 'local'
# keyword is, otherwise the sourcing of this file will fail for ksh...
stat=($(< /proc/self/stat))
base_stime=${stat[21]}
base_stime=$(cut -d" " -f22 /proc/$$/stat)

if [ "$1" = "-d" ]; then
delay=$2
Expand Down