This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Conversation
Closed
buffalojoec
reviewed
Jan 16, 2025
Comment on lines
+29
to
+35
| if std::env::var("SBF_OUT_DIR").is_err() { | ||
| println!( | ||
| "{} SBF_OUT_DIR is not set. Please set it to the output directory of the BPF build.", | ||
| style("[ 🔴 ERROR ]").red(), | ||
| ); | ||
| std::process::exit(1); | ||
| } |
Collaborator
There was a problem hiding this comment.
If you want, you can have the CLI take the program binary path as an argument, and just use load_program_elf as well as add_program_with_elf_and_loader.
buffalojoec
reviewed
Jan 16, 2025
Collaborator
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
Let me know if something like this works. Otherwise might as well ship your version for p-token.
* Remove spl-token test cases * Update CU values * Add safety comments * Use git dependencies
joncinque
reviewed
Feb 3, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Sorry for the slowness looking at this, but it looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to run
spl-tokenfixtures against thep-token(343fixtures in total).The main additions of this PR:
spl-tokenrepository and generate the fixtures from its tests