Enhance paramsForServer with parameters with specific values.

[Yavorss]

Summary

This a solution to the issue with -1 from feathers-hooks-common mentioned here #590. The solution is simple. Instead of filtering only by parameter, we could filter by parameter with a specific value. For instance, paramsForServer: [['$limit', '-1']] or paramsForServer: [['$limit', value => value === '-1']]. This is not a breaking change.

Other Information

If that looks good for the team, we could update the documentation and link that PR to here as well.

[J3m5]

Please, take a look at my comment there

[joshuaja]

@J3m5 Allowing a filtering function within theparamsForServer solves the $limit: -1 issue and also adds some needed functionality to the paramsForServer filter.

That would be a more straightforward solution over hard-coding the -1 in multiple places within the code and enhances the utility of paramsForServer at the same time.

[J3m5]

Ok I get it.

There is one small problem however.
This MR will conflict with a previous one

And I think the added code could be isolated in a separate function.

[marshallswain]

This is a good idea. Can you double check the conflicts from the other PRs merged?

[Yavorss]

This is a good idea. Can you double check the conflicts from the other PRs merged?

Will update it these days or even today.

[fratzinger]

Pretty nice! I also thought about this before.

A mention about this in the docs would be pretty neat! @Yavorss could you add this to the docs?

[marshallswain]

@Yavorss were you able to make any additional progress on this. I should have some time soon to take a look, if not.