Move Console Report out of Status Reporter #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor Skunk analysis integration by removing the Analysis class and adding its methods directly to RubyCritic::AnalysedModulesCollection. Update related files to utilize the new methods for Skunk score calculations and reporting.
The status reporter has a different purpuse in the RubyCritic gem, they also have the specific usage of the Console Report and now we are following the same patters that gem created. - Added support for a new console output format in the FormatValidator module. - Refactored the StatusReporter to provide a simplified status message upon completion of analysis. - Introduced ConsoleReport and Simple classes for generating detailed console reports of analysed modules. - Updated tests to validate new console reporting functionality and ensure expected outputs. - Adjusted existing tests to reflect changes in the status reporting method.
JuanVqz
force-pushed
the
feat/move-console-report
branch
from
f7c8983 to
21741eb
Compare
This class used to return the Console message but now it does not have that responsibility and will only return an empty string until we get the GPA Score on Skunk, we will print it as RubyCritic does
JuanVqz
force-pushed
the
feat/move-console-report
branch
from
21741eb to
2b5e5b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The status reporter has a different purpuse in the RubyCritic gem, they also have the specific usage of the Console Report and now we are following the same patters that gem created.
Added support for a new console output format in the FormatValidator module.
Refactored the StatusReporter to provide a simplified status message upon completion of analysis.
Introduced ConsoleReport and Simple classes for generating detailed console reports of analysed modules.
Updated tests to validate new console reporting functionality and ensure expected outputs.
Adjusted existing tests to reflect changes in the status reporting method.
Add an entry to
CHANGELOG.mdthat links to this PR under the "main (unreleased)" heading.I will abide by the code of conduct.