Skip to content

chore: upgrade deps #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ilteoood wants to merge 1 commit into from
Closed

chore: upgrade deps #554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,23 +58,23 @@
}
],
"dependencies": {
"@fastify/accept-negotiator": "^2.0.0",
"@fastify/send": "^4.0.0",
"@fastify/accept-negotiator": "^2.0.1",
"@fastify/send": "^4.1.0",
"content-disposition": "^1.0.1",
"fastify-plugin": "^5.0.0",
"fastq": "^1.17.1",
"fastify-plugin": "^5.1.0",
"fastq": "^1.20.1",
"glob": "^13.0.0"
},
"devDependencies": {
"@fastify/compress": "^8.0.0",
"@types/node": "^25.0.3",
"borp": "^0.20.0",
"@fastify/compress": "^8.3.1",
"@types/node": "^25.0.5",
"borp": "^0.21.0",
"c8": "^10.1.3",
"concat-stream": "^2.0.0",
"eslint": "^9.17.0",
"fastify": "^5.1.0",
"neostandard": "^0.12.0",
"pino": "^9.1.0",
"eslint": "^9.39.2",
"fastify": "^5.6.2",
"neostandard": "^0.12.2",
"pino": "^10.1.1",
Copy link
Member

@mcollina mcollina Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be updated to a new major.

Copy link
Contributor Author

@ilteoood ilteoood Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcollina
Just for my knowledge, can I understand why?
It is a dev dependency here and is used in a test, so even upgrading it to the major version we don't need to release it as breaking change.

Copy link
Member

@jean-michelet jean-michelet Jan 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we usually randomly upgrade dependencies on packages @fastify/leads?

It is a dev dependency here and is used in a test, so even upgrading it to the major version we don't need to release it as breaking change.

Assumption: even if this is a devDependency and only used in tests, upgrading to a new major effectively changes the version we test against. I don't know if it's an issue here.

Copy link
Member

@mcollina mcollina Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pino ships with pino 9 and tests against pino 9.

"proxyquire": "^2.1.3",
"tsd": "^0.33.0"
},
Expand Down
Loading