Open
Conversation
Contributor
|
I might be missing something but the code you wrote seems the exact same as I think the actual issue is that you just need to call |
Author
Indeed, but the argument for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with a Google Workspace SMTP relay. Since that uses IP address authentication, we don't directly do smtp.Dial, since then the local name is set to localhost. Instead, we use net.Dial so we get the connection struct from which we can actually get the local address hostname and then do client.Hello to actually set it. Don't know why Go doesn't do this by default, Python worked fine and took forever to find out why Go wasn't working.
Somewhat opinionated since I assume TLS is required. I think it's best to leave that as the default. Messages are super simple, but do use the time and displayName if it is set.