Skip to content

Conversation

@jason-famedly
Copy link
Contributor

@jason-famedly jason-famedly commented Jan 14, 2026

See each commit for details of what changed.

The biggest motivator for this was having the rust cache causing warnings in CI because the service being connected to was returning 400 status codes

Updating the rust-cache action should save about 1 minute from eligible jobs

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.08%. Comparing base (6883625) to head (0bb4383).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   80.09%   80.08%   -0.01%     
==========================================
  Files         498      498              
  Lines       70863    70863              
  Branches    10636    10636              
==========================================
- Hits        56756    56750       -6     
- Misses      10869    10874       +5     
- Partials     3238     3239       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6883625...0bb4383. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This action is not necessary or used here. Synapse is installed into a
docker image, and that means the rust building is not accessible from
the Github runner environment.

This is the output from the action:
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code
101
    at ExecState._setResult
(/home/runner/work/_actions/Swatinem/rust-cache/98c8021b550208e191a6a3145459bfc9fb29c4c0/dist/restore/index.js:9728:25)
    at ExecState.CheckComplete
(/home/runner/work/_actions/Swatinem/rust-cache/98c8021b550208e191a6a3145459bfc9fb29c4c0/dist/restore/index.js:9711:18)
    at ChildProcess.<anonymous>
(/home/runner/work/_actions/Swatinem/rust-cache/98c8021b550208e191a6a3145459bfc9fb29c4c0/dist/restore/index.js:9605:27)
    at ChildProcess.emit (node:events:524:28)
    at maybeClose (node:internal/child_process:1104:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5) {
  commandFailed: {
    command: 'cargo metadata --all-features --format-version 1
--no-deps',
    stderr: 'error: could not find `Cargo.toml` in
`/home/runner/work/synapse/synapse` or any parent directory\n'
  }
}
@jason-famedly
Copy link
Contributor Author

Example test of before: https://github.com/famedly/synapse/actions/runs/20995087390
Note the 45 warning annotations at the bottom

Example test of first run: https://github.com/famedly/synapse/actions/runs/20997454479
Note the 23 warnings are different, as the cache is only now being established(and in some cases it was found to exist after the fact). These should go away on the next run that uses the cache. Whenever the cache is updated, the 409 warnings will come back(and can be ignored)

Example test using cache correctly: https://github.com/famedly/synapse/actions/runs/20999946434

@jason-famedly jason-famedly marked this pull request as ready for review January 14, 2026 16:26
@jason-famedly jason-famedly requested a review from a team as a code owner January 14, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants