Skip to content

Conversation

@FrenchGithubUser
Copy link
Contributor

This change was applied to the token-authenticator accidentally. This commits moves it to the invite checker

@FrenchGithubUser FrenchGithubUser requested a review from a team as a code owner January 13, 2026 08:46
itsoyou
itsoyou previously approved these changes Jan 13, 2026
@FrenchGithubUser FrenchGithubUser force-pushed the thomast/fix-token-auth-ci branch from 208fcbf to 48c5b39 Compare January 13, 2026 08:52
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.01%. Comparing base (b958daf) to head (eaeb87f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files         498      498           
  Lines       70635    70635           
  Branches    10615    10615           
=======================================
  Hits        56522    56522           
+ Misses      10882    10881    -1     
- Partials     3231     3232    +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b958daf...eaeb87f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrenchGithubUser FrenchGithubUser force-pushed the thomast/fix-token-auth-ci branch 9 times, most recently from 3d79184 to fc81f63 Compare January 13, 2026 16:10
@FrenchGithubUser FrenchGithubUser changed the title ci: ci: fix tests failing as the invite-checker's synapse dependency is already pointing to the master branch. ci: genereate requirements.txt file from synapse's poetry.lock for invite-checker and token-authenticator tests Jan 13, 2026
@FrenchGithubUser FrenchGithubUser force-pushed the thomast/fix-token-auth-ci branch from fc81f63 to 4b9ab82 Compare January 13, 2026 16:17
@FrenchGithubUser FrenchGithubUser force-pushed the thomast/fix-token-auth-ci branch from 4b9ab82 to b917fe3 Compare January 13, 2026 16:33
invite-checker and token-authenticator tests

this forces them from using the same version for synapse's dependencies
as synapse itself, and prevents the tests from breaking when breaking
changes are released for a dependency
@FrenchGithubUser FrenchGithubUser force-pushed the thomast/fix-token-auth-ci branch from b917fe3 to eaeb87f Compare January 13, 2026 16:36
@jason-famedly
Copy link
Contributor

Depends on famedly/synapse-token-authenticator#75
Once that is merged, rerun tests here(make sure nothing broke) and you'll get an approval

@jason-famedly jason-famedly changed the title ci: genereate requirements.txt file from synapse's poetry.lock for invite-checker and token-authenticator tests ci: generate requirements.txt file from synapse's poetry.lock for invite-checker and token-authenticator tests Jan 14, 2026
Copy link
Contributor

@jason-famedly jason-famedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good deal. Looks like it worked beautifully

@FrenchGithubUser FrenchGithubUser merged commit 81ee8fb into master Jan 14, 2026
52 of 53 checks passed
@FrenchGithubUser FrenchGithubUser deleted the thomast/fix-token-auth-ci branch January 14, 2026 11:24
jason-famedly pushed a commit that referenced this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants