Add support for torch.set_default_device when initializing model parameters#1158
Open
fshp971 wants to merge 1 commit intofacebookresearch:mainfrom
Open
Add support for torch.set_default_device when initializing model parameters#1158fshp971 wants to merge 1 commit intofacebookresearch:mainfrom
torch.set_default_device when initializing model parameters#1158fshp971 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
…llel/layers.py` to support `torch.set_default_device`
|
I just hit this myself, and while I am not an expert in this particular project, I think it would be a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace
torch.Tensorwithtorch.emptywhen initializing model parameters.The reason is that
torch.emptyis compatible withtorch.set_default_device(buttorch.Tensoris not), thus enable one to efficiently initialize a large ML model with specified GPUs.(An example is that initialize a Llama2 model with the default
torch.nn.init.xavier_normal_method is extremely slow on CPUs, but very fast on GPUs.)Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.