Skip to content

fix(DevTools): handle race condition when adding fibers during page reload #36019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
w2jiodsfa wants to merge 1 commit into from
+4 −3
Closed

fix(DevTools): handle race condition when adding fibers during page reload #36019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,11 @@ function updateTree(

i += 3;

// If the node already exists, it may be a race condition when the page
// reloads during profiling. In this case, remove the old node first
// before adding the new one.
if (nodes.has(id)) {
throw new Error(
`Commit tree already contains fiber "${id}". This is a bug in React DevTools.`,
);
nodes.delete(id);
}

if (type === ElementTypeRoot) {
Expand Down