Make removeClippedSubviews toggle-resilient (#56211)#56211
Open
javache wants to merge 1 commit intofacebook:mainfrom
Open
Make removeClippedSubviews toggle-resilient (#56211)#56211javache wants to merge 1 commit intofacebook:mainfrom
javache wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
meta-codesync
bot
changed the title
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 24, 2026
Summary: The `removeClippedSubviews` prop toggle path in `RCTViewComponentView` did not handle being turned off: children that were clipped (removed from superview) remained invisible, and `_reactSubviews` became stale. This diff: - Adds `_updateRemoveClippedSubviewsState` helper that ensures consistent state when toggling. On toggle-off, re-mounts all children from `_reactSubviews` in the correct order and clears the tracking array. - Makes the unmount path resilient by cleaning up `_reactSubviews` even when `removeClippedSubviews` is off. - Splits the unmount assert into two distinct messages: "not mounted" vs "mounted inside a different view". - Adds unit tests covering toggle-off re-mounting, ordering, cleanup, and unmount-after-toggle scenarios. Changelog: [iOS][Fixed] Fixes crash when changing the value of `removeClippedSubviews` Differential Revision: D97971845
javache
force-pushed
the
export-D97971845
branch
from
085bb2e to
1eb4a77
Compare
Summary: Pull Request resolved: facebook#56211 The `removeClippedSubviews` prop toggle path in `RCTViewComponentView` did not handle being turned off: children that were clipped (removed from superview) remained invisible, and `_reactSubviews` became stale. This diff: - Adds `_updateRemoveClippedSubviewsState` helper that ensures consistent state when toggling. On toggle-off, re-mounts all children from `_reactSubviews` in the correct order and clears the tracking array. - Makes the unmount path resilient by cleaning up `_reactSubviews` even when `removeClippedSubviews` is off. - Splits the unmount assert into two distinct messages: "not mounted" vs "mounted inside a different view". - Adds unit tests covering toggle-off re-mounting, ordering, cleanup, and unmount-after-toggle scenarios. Changelog: [iOS][Fixed] Fixes crash when changing the value of `removeClippedSubviews` Differential Revision: D97971845
javache
force-pushed
the
export-D97971845
branch
from
1eb4a77 to
0cc4c35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
removeClippedSubviewsprop toggle path inRCTViewComponentViewdid nothandle being turned off: children that were clipped (removed from superview)
remained invisible, and
_reactSubviewsbecame stale.This diff:
_updateRemoveClippedSubviewsStatehelper that ensures consistent statewhen toggling. On toggle-off, re-mounts all children from
_reactSubviewsinthe correct order and clears the tracking array.
_reactSubviewseven whenremoveClippedSubviewsis off."mounted inside a different view".
unmount-after-toggle scenarios.
Changelog: [iOS][Fixed] Fixes crash when changing the value of
removeClippedSubviewsDifferential Revision: D97971845