Remove double-conversion dependency from DoubleConversions.cpp (#56110)#56110
Open
christophpurrer wants to merge 2 commits intofacebook:mainfrom
Open
Remove double-conversion dependency from DoubleConversions.cpp (#56110)#56110christophpurrer wants to merge 2 commits intofacebook:mainfrom
christophpurrer wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96082175. |
meta-codesync
bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Mar 16, 2026
…ook#56110) Summary: **Summary** Removes the `double-conversion` dependency from `DoubleConversions.cpp` in the React Native repository. - Removed Dependencies: `double-conversion/double-conversion.h` Updated Code * Modified `DoubleConversions.cpp` to use standard C++ library headers (`cmath` and `cstdio`) instead of `double-conversion`. This change aims to reduce dependencies and simplify the codebase. The removed dependency was previously used for string conversion, which has been replaced with standard C++ library functions. Changelog: [Internal] Differential Revision: D96082175
christophpurrer
force-pushed
the
export-D96082175
branch
from
2f1e137 to
e642877
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Mar 16, 2026
…ook#56110) Summary: Pull Request resolved: facebook#56110 **Summary** Removes the `double-conversion` dependency from `DoubleConversions.cpp` in the React Native repository. - Removed Dependencies: `double-conversion/double-conversion.h` Updated Code * Modified `DoubleConversions.cpp` to use standard C++ library headers (`cmath` and `cstdio`) instead of `double-conversion`. This change aims to reduce dependencies and simplify the codebase. The removed dependency was previously used for string conversion, which has been replaced with standard C++ library functions. Changelog: [Internal] Differential Revision: D96082175
christophpurrer
force-pushed
the
export-D96082175
branch
from
e642877 to
f764c1e
Compare
Summary: Add comprehensive unit tests for the `toString(double, char)` function in `DoubleConversions.cpp`. The tests cover: - Zero and negative zero - Positive and negative integers - Fractional values - Very small and very large values - Scientific notation for values below 1e-6 - Infinity and NaN serialization as "0" - Suffix character appending (including null suffix) - Suffix behavior with special values (infinity, NaN) Changelog: [Internal] Differential Revision: D96625901
christophpurrer
force-pushed
the
export-D96082175
branch
from
f764c1e to
88432c0
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Mar 16, 2026
…ook#56110) Summary: **Summary** Removes the `double-conversion` dependency from `DoubleConversions.cpp` in the React Native repository. - Removed Dependencies: `double-conversion/double-conversion.h` Updated Code * Modified `DoubleConversions.cpp` to use standard C++ library headers (`cmath` and `cstdio`) instead of `double-conversion`. This change aims to reduce dependencies and simplify the codebase. The removed dependency was previously used for string conversion, which has been replaced with standard C++ library functions. Changelog: [Internal] Differential Revision: D96082175
…ook#56110) Summary: Pull Request resolved: facebook#56110 **Summary** Removes the `double-conversion` dependency from `DoubleConversions.cpp` in the React Native repository. - Removed Dependencies: `double-conversion/double-conversion.h` Updated Code * Modified `DoubleConversions.cpp` to use standard C++ library headers (`cmath` and `cstdio`) instead of `double-conversion`. This change aims to reduce dependencies and simplify the codebase. The removed dependency was previously used for string conversion, which has been replaced with standard C++ library functions. Changelog: [Internal] Differential Revision: D96082175
christophpurrer
force-pushed
the
export-D96082175
branch
from
88432c0 to
d64f818
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
Removes the
double-conversiondependency fromDoubleConversions.cppin the React Native repository.double-conversion/double-conversion.hUpdated Code
DoubleConversions.cppto use standard C++ library headers (cmathandcstdio) instead ofdouble-conversion.This change aims to reduce dependencies and simplify the codebase. The removed dependency was previously used for string conversion, which has been replaced with standard C++ library functions.
Changelog: [Internal]
Differential Revision: D96082175