Add unit tests for DoubleConversions::toString (#56109)#56109
Closed
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Closed
Add unit tests for DoubleConversions::toString (#56109)#56109christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96625901. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Mar 16, 2026
Summary: Add comprehensive unit tests for the `toString(double, char)` function in `DoubleConversions.cpp`. The tests cover: - Zero and negative zero - Positive and negative integers - Fractional values - Very small and very large values - Scientific notation for values below 1e-6 - Infinity and NaN serialization as "0" - Suffix character appending (including null suffix) - Suffix behavior with special values (infinity, NaN) Changelog: [Internal] Differential Revision: D96625901
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Mar 16, 2026
Summary: Add comprehensive unit tests for the `toString(double, char)` function in `DoubleConversions.cpp`. The tests cover: - Zero and negative zero - Positive and negative integers - Fractional values - Very small and very large values - Scientific notation for values below 1e-6 - Infinity and NaN serialization as "0" - Suffix character appending (including null suffix) - Suffix behavior with special values (infinity, NaN) Changelog: [Internal] Differential Revision: D96625901
meta-codesync
bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Mar 16, 2026
Summary: Add comprehensive unit tests for the `toString(double, char)` function in `DoubleConversions.cpp`. The tests cover: - Zero and negative zero - Positive and negative integers - Fractional values - Very small and very large values - Scientific notation for values below 1e-6 - Infinity and NaN serialization as "0" - Suffix character appending (including null suffix) - Suffix behavior with special values (infinity, NaN) Changelog: [Internal] Differential Revision: D96625901
christophpurrer
force-pushed
the
export-D96625901
branch
from
f57cd41 to
8454444
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Mar 16, 2026
Summary: Add comprehensive unit tests for the `toString(double, char)` function in `DoubleConversions.cpp`. The tests cover: - Zero and negative zero - Positive and negative integers - Fractional values - Very small and very large values - Scientific notation for values below 1e-6 - Infinity and NaN serialization as "0" - Suffix character appending (including null suffix) - Suffix behavior with special values (infinity, NaN) Changelog: [Internal] Differential Revision: D96625901
Summary: Pull Request resolved: facebook#56109 Add comprehensive unit tests for the `toString(double, char)` function in `DoubleConversions.cpp`. The tests cover: - Zero and negative zero - Positive and negative integers - Fractional values - Very small and very large values - Scientific notation for values below 1e-6 - Infinity and NaN serialization as "0" - Suffix character appending (including null suffix) - Suffix behavior with special values (infinity, NaN) Changelog: [Internal] Differential Revision: D96625901
christophpurrer
force-pushed
the
export-D96625901
branch
from
8454444 to
2e50fca
Compare
|
This pull request has been merged in ceb1e88. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in ceb1e88 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add comprehensive unit tests for the
toString(double, char)function inDoubleConversions.cpp. The tests cover:Changelog: [Internal]
Differential Revision: D96625901