Skip to content

Fixing unreachable-code-return in react-native-github (#56093) #56093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ingridwang wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Fixing unreachable-code-return in react-native-github (#56093) #56093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/React/Profiler/RCTProfile.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ void RCTProfileHookModules(RCTBridge *bridge)

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wtautological-pointer-compare"
#pragma clang diagnostic ignored "-Wunreachable-code-return"
if (RCTProfileTrampoline == NULL) {
return;
}
Expand Down
3 changes: 3 additions & 0 deletions ...act-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,10 @@ static int32_t getUniqueId()
return ^(NSArray *args) {
if (!callback) {
LOG(FATAL) << "Callback arg cannot be called more than once";
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunreachable-code-return"
return;
#pragma clang diagnostic pop
}

callback->call([args](jsi::Runtime &rt, jsi::Function &jsFunction) {
Expand Down