fix: upgrade foojay-resolver-convention to 1.0.0#54160
fix: upgrade foojay-resolver-convention to 1.0.0#54160TheNerdGuyLulu wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @TheNerdGuyLulu! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
I don't believe this is needed for Gradle 9.0.0 |
|
Hi @cortinico, It might be related to usage with openjdk@25. Apparently works fine with openjdk@21. |
Open JDK 25 is not supported yet sadly |
I believe it is, see e.g.
The issue only surfaces if Gradle's toolchain mechanism is actually triggered to bootstrap a JDK in the desired version via the foojay resolver. So can we please reopen this @cortinico? |
@sschuberth can you open a new PR please. We do have a dedicated workflow that triggers whenever a new PR gets opened and it would help us make sure this gets addressed |
Summary:
foojay-resolver-convention's version 0.5.0 is not compatible with Gradle 9. (gradle/foojay-toolchains#151)
When trying to build for Android on React Native 0.8.2, we are presented with
Changelog:
Test Plan:
After making the change, the app build without problems.