Fix: Detect type errors for bare return statements (#1508) #1524
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes 1. Added `range` field to `ReturnExplicit` struct to track the return statement location 2. Updated `binding/function.rs` to pass the range when creating `ReturnExplicit` 3. Added type checking in `solve.rs` for bare return ## Testing - ✅ Added 3 new test cases in returns.rs Fixes facebook#1508
kinto0
approved these changes
Nov 7, 2025
ndmitchell
approved these changes
Nov 8, 2025
Contributor
ndmitchell
left a comment
ndmitchell
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
rangefield toReturnExplicitstruct to track the return statement locationbinding/function.rsto pass the range when creatingReturnExplicitsolve.rsfor bare returnTesting
Fixes #1508