Skip to content

Conversation

@ec-michael-shih
Copy link
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running
    pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
clang-format.............................................................Passed
black................................................(no files to check)Skipped
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped

Summary

The new wedge800cact platform requires the execution of the following T0 Validation Tests:

  1. LED Service Hardware Test
  2. QSFP Hardware Tests

To meet these requirements, I have implemented new files to support the platform for testing.
Following the New platform support guide, I have added and modified the following related code:

Add:

fboss/led_service/Minipack3BTALedManager.cpp
fboss/led_service/Minipack3BTALedManager.h
fboss/lib/bsp/bspmapping/input/Minipack3BTA_BspMapping.csv
fboss/lib/bsp/minipack3bta/BUCK
fboss/lib/bsp/minipack3bta/Minipack3BTABspPlatformMapping.cpp
fboss/lib/bsp/minipack3bta/Minipack3BTABspPlatformMapping.h

Modify:

cmake/LedService.cmake
cmake/QsfpService.cmake
cmake/QsfpServicePlatformsWedge.cmake
fboss/led_service/LedManagerInit.cpp
fboss/qsfp_service/platforms/wedge/WedgeManagerInit.cpp

Despite the files added and modified above, further changes to the following files are necessary to ensure the tests run successfully:

Additional changes:

fboss/led_service/BUCK
fboss/lib/bsp/BUCK
fboss/lib/bsp/BspGenericSystemContainer.cpp
fboss/lib/bsp/bspmapping/Main.cpp
fboss/lib/bsp/bspmapping/Parser.h
fboss/lib/bsp/bspmapping/input/Minipack3BTA_BspMapping.csv
fboss/lib/bsp/bspmapping/test/ParserTest.cpp
fboss/qsfp_service/test/BUCK
fboss/qsfp_service/test/BspPlatformMapTest.cpp
fboss/util/BUCK
fboss/util/wedge_qsfp_util.cpp

@meta-cla meta-cla bot added the CLA Signed label Jan 27, 2026
@ec-michael-shih ec-michael-shih changed the title [Accton][minipack3bta] Support for QSFP and LED Service Codes on the … [Accton][minipack3bta] Support QSFP and LED service codes on new platform Jan 28, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 29, 2026

@ashutoshgrewal has imported this pull request. If you are a Meta employee, you can view this in D91743931.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant