Skip to content

Conversation

@cbarrete
Copy link
Contributor

@cbarrete cbarrete commented Dec 7, 2025

…macros

Closes #1166.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 7, 2025
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Dec 7, 2025

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D88573758. (Because this pull request was imported automatically, there will not be any future comments.)

@cormacrelf
Copy link
Contributor

I don't really see how this is specific to string parameter macros. I practically never use string parameter macros and I still need to know this. It's perhaps better placed on RunInfo because being a runtime dependency is the main reason you need something materialized, or in the docs on materialization generally.

For RunInfo, you also have the ability to put hidden artifacts in RunInfo's cmd_args. I am not sure whether we materialize DefaultInfo (and other_outputs) when you run an associated RunInfo, but you could check and document what we do.

@cbarrete
Copy link
Contributor Author

cbarrete commented Dec 7, 2025

I don't really see how this is specific to string parameter macros. I practically never use string parameter macros and I still need to know this. It's perhaps better placed on RunInfo because being a runtime dependency is the main reason you need something materialized, or in the docs on materialization generally.

I guess this really depends on use cases. For example, the most common use case in my org is to actually expose shared libraries, not binaries, so DefaultInfo is relevant, not RunInfo. But more importantly, end users barely know/care about providers, they care about what they actually use, which is SPM. They will not even think of checking out the docs for providers, because it is not the level of abstraction that they operate at.

So while I don't mind also adding a page on materialization (there doesn't seem to be one yet, only https://buck2.build/docs/users/advanced/deferred_materialization/), I think that it is important to have this here as well.

For RunInfo, you also have the ability to put hidden artifacts in RunInfo's cmd_args. I am not sure whether we materialize DefaultInfo (and other_outputs) when you run an associated RunInfo, but you could check and document what we do.

DefaultInfo does not get built, much less materialized, when calling buck2 run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

String parameter macro artifacts are not materialized when cached or built remotely

2 participants