buck2_error -> lsp diagnostics#1152

Open

cormacrelf wants to merge 25 commits intofacebook:mainfrom

cormacrelf:buck2-error-lsp-diagnostics

Commits on Nov 27, 2025

Follow #{track_caller] to something that likely meant to use it
cormacrelf
committed
Ignore target/ folder for OSS buck2 developers
cormacrelf
committed
Document why not to use EvalMessage::from_any_error
cormacrelf
committed
Add note about unlikely wanted behaviour
cormacrelf
committed
Always attach StarlarkContext
cormacrelf
committed
Store a real CallStack in StarlarkContext
cormacrelf
committed
Add a missing enum value to match starlark_syntax::ErrorKind
cormacrelf
committed
Document recover_crate_error
cormacrelf
committed
Rename error_with_starlark_context to inject_starlark_context
cormacrelf
committed
Fix a misplaced backtick
cormacrelf
committed
Add buck2_error::Error::find_starlark_context for tests
cormacrelf
committed
Make StarlarkContext replace the root error, at format time
cormacrelf
committed
Update out-of-date doc strings on buck2_error::ErrorKind
cormacrelf
committed
impl Debug for ContextValue
cormacrelf
committed
Find relevant spans for lsp file in call stacks as well as directly attached
cormacrelf
committed
Add show_span_in_buck_output flag on StarlarkContext
cormacrelf
committed
Add a function to create_starlark_context
cormacrelf
committed
Test for formatting starlark errors via buck
cormacrelf
committed
buck2_error::Error::into_lsp_diagnostic
cormacrelf
committed
Integrate buck2_error::Error::into_lsp_diagnostic with LSP
cormacrelf
committed
Add test_recover_starlark_span_through_context
cormacrelf
committed
Add starlark span to 'From load at BUCK:4'
cormacrelf
committed
Add starlark span to invalid load errors
cormacrelf
committed
Add a test for create_starlark_context
cormacrelf
committed
Preserve error messages when we concatenate starlark call stacks
cormacrelf
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

buck2_error -> lsp diagnostics#1152

buck2_error -> lsp diagnostics#1152
cormacrelf wants to merge 25 commits intofacebook:mainfrom
cormacrelf:buck2-error-lsp-diagnostics

Commits on Nov 27, 2025

Follow #{track_caller] to something that likely meant to use it

Ignore target/ folder for OSS buck2 developers

Document why not to use EvalMessage::from_any_error

Add note about unlikely wanted behaviour

Always attach StarlarkContext

Store a real CallStack in StarlarkContext

Add a missing enum value to match starlark_syntax::ErrorKind

Document recover_crate_error

Rename error_with_starlark_context to inject_starlark_context

Fix a misplaced backtick

Add buck2_error::Error::find_starlark_context for tests

Make StarlarkContext replace the root error, at format time

Update out-of-date doc strings on buck2_error::ErrorKind

impl Debug for ContextValue

Find relevant spans for lsp file in call stacks as well as directly attached

Add show_span_in_buck_output flag on StarlarkContext

Add a function to create_starlark_context

Test for formatting starlark errors via buck

buck2_error::Error::into_lsp_diagnostic

Integrate buck2_error::Error::into_lsp_diagnostic with LSP

Add test_recover_starlark_span_through_context

Add starlark span to 'From load at BUCK:4'

Add starlark span to invalid load errors

Add a test for create_starlark_context

Preserve error messages when we concatenate starlark call stacks