Skip to content

Comments

[On-HOLD] feat: Ignore vulnerability feature for VA#817

Open
AkshayBhansali18 wants to merge 5 commits intofabric8-analytics:masterfrom
AkshayBhansali18:ignore-va-vuln
Open

[On-HOLD] feat: Ignore vulnerability feature for VA#817
AkshayBhansali18 wants to merge 5 commits intofabric8-analytics:masterfrom
AkshayBhansali18:ignore-va-vuln

Conversation

@AkshayBhansali18
Copy link
Contributor

Ignore vulnerability feature for VA with test cases

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #817 (d32d5c4) into master (a8c33bc) will decrease coverage by 0.13%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
- Coverage   79.33%   79.19%   -0.14%     
==========================================
  Files          21       21              
  Lines        1679     1692      +13     
==========================================
+ Hits         1332     1340       +8     
- Misses        347      352       +5     
Impacted Files Coverage Δ
bayesian/utility/v2/component_analyses.py 90.00% <61.53%> (-1.83%) ⬇️
bayesian/api/api_v2.py 74.47% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8c33bc...d32d5c4. Read the comment docs.

Copy link
Member

@rafiu007 rafiu007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests.

@rafiu007
Copy link
Member

@jparsai Do we really need this for VA? VA is very specific for clair.

@jparsai
Copy link
Contributor

jparsai commented Oct 29, 2021

@rafiu007 Dont we want to ignore in Clair?

@rafiu007
Copy link
Member

@rafiu007 Dont we want to ignore in Clair?

I cant think of a use case where we would like to ignore. By default clair serves all packages

@jparsai
Copy link
Contributor

jparsai commented Oct 29, 2021

Okay, for now we can keep this PR open, later if Clair requires ignore feature we can take this PR in.

@jparsai jparsai changed the title Ignore vulnerability feature for VA [On-HOLD] feat: Ignore vulnerability feature for VA Oct 29, 2021
Copy link
Contributor

@jparsai jparsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it On-Hold as Clair may not need this feature yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants