-
Notifications
You must be signed in to change notification settings - Fork 12
[COVPN-65] Make wolfssl as Lightway's cargo dependency #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Code coverage summary for f1335fe: ✅ Region coverage 72% passes |
cbc2ca2 to
28e4273
Compare
ba912c3 to
ea23d69
Compare
.github/workflows/release.yaml
Outdated
| if (version_on_file != version_on_crate_io) { | ||
| console.log(`✓ ${name}: ${version_on_crate_io} → ${version_on_file}`) | ||
| bump_details.push(`${name}: ${version_on_crate_io} → ${version_on_file}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably also compare the 2 versions and make the version on file is actually newer than the one on crate io (instead of just checking they're different)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more detailed checks for versions on file and crates io, it will now fail CI if the version of any of the releases is lower than crates io.
README.md
Outdated
| 1. Observe that a comment is add to the PR, indicating the current version and the upcoming version | ||
| 1. Merge the PR, a new version should be released to both GitHub and Crates.io | ||
|
|
||
| If no version bump is present and no `ignore-release` label is set, CI will block the workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should explain when we should use ignore-release. This should only be done on chore/ci PRs where there is no code change. Unless there is a good reason, we want to make a release every new change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added explanation on the usage of ignore-release.
.github/workflows/release.yaml
Outdated
| - uses: ./.github/actions/check-dependencies | ||
| id: check_dependencies | ||
|
|
||
| - name: Check semver compliance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently with this check, CIs will fail because the version published on crates io is outdated against the current code. Maybe we can comment this out first and add this back in after version on crates io has caught up.
🚀 Release Plan
|
aadca60 to
3b2d629
Compare
…on is too outdated
Since we are trying to use cargo dependency, we need to make sure that all new changes to wolfssl will be released into crates.io, then we won't need to use it as a git dependency to get the latest changes.
We can enforce updating of the version inside *.toml by blocking the CI if either wolfssl or wolfssl-sys does not have a version bump.
We can also add a bypass the release CI by adding label on the PR like skip-release, and it will not release into crates.io.