-
-
Notifications
You must be signed in to change notification settings - Fork 22.9k
Unit test cases for uncovered lines for response.js file #7105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ashish3011
wants to merge
6
commits into
expressjs:master
Choose a base branch
from
ashish3011:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
eeaf6bc
increased code coverage of utils.js file
ashish3011 64c1a4c
Merge branch 'master' of github.com:expressjs/express into ashish3011…
bjohansebas ceca223
Merge remote-tracking branch 'express/master'
ashish3011 576ce52
added new test cases for covering uncovered lines of response.js file
ashish3011 daaa05d
Update feedback reviewed
ashish3011 175e645
error fix
ashish3011 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you checking here for a deprecation warning? I don't see any code that would verify if there is a warning. These tests would also pass without #6405.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback!
You're correct that the tests only verify the deprecated behaviour, not the warnings themselves. However, since deprecation warnings for Express are suppressed in the test environment via [NO_DEPRECATION](to avoid noise), the tests focus on ensuring the deprecated code paths are executed, which is confirmed by coverage reports showing lines 824, 828, and 832 in lib/response.js are hit.
The tests would indeed pass without the deprecation calls if the behaviour remained the same, but since the goal is coverage, these tests ensure the deprecation logic runs. If you'd like explicit warning checks, we could modify the test environment to enable them, but that might introduce noise in CI. Let me know if you'd prefer that approach!
The changes ensure the targeted lines are covered while maintaining test stability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just "covering" some lines without checking if they do what they are supposed to do does not make sense in my opinion.
The tests are named "should deprecate", so I consider not checking this behaviour a problem.