Skip to content

Conversation

@metaspartan
Copy link
Contributor

Updated hardware monitoring tools in the README.

Motivation

Changes

Why It Works

Test Plan

Manual Testing

Automated Testing

Updated hardware monitoring tools in the README.
@Evanev7
Copy link
Member

Evanev7 commented Dec 22, 2025

We may integrate mactop in future, but for now we definitely use macmon.

@Evanev7 Evanev7 closed this Dec 22, 2025
@metaspartan
Copy link
Contributor Author

metaspartan commented Dec 22, 2025

@Evanev7 Can't have both listed? mactop has many more features than macmon, also mactop will have thunderbolt/rdma detection support soon.

@Evanev7
Copy link
Member

Evanev7 commented Dec 22, 2025

No. this isn't an endorsement of macmon, it's a dependency on macmon. We cannot simply substitute macmon for mactop and expect things to work.

Also, as the developer of mactop this feels like bad-faith advertising of your own project, not a contribution to ours.

If you wish to contribute a working PR that replaces our macmon dependency with mactop I'd gladly review it, but that is not what this PR is.

@metaspartan
Copy link
Contributor Author

I guess I read the readme wrong, didnt see the "Pre-reqs", didn't realize you guys were using it in that way, mactop does have a programmable headless mode now though, so ya I will look into swapping over in another PR, thanks.

@Evanev7
Copy link
Member

Evanev7 commented Dec 22, 2025

My apologies if that was a little blunt, we've had a lot of spam on the repo today - integrating lots of data sources is a goal for me and if mactop's rdma connectivity ends up better than shelling out to system_profiler (which is what we currently do in #928) i'd gladly integrate it myself.

@metaspartan
Copy link
Contributor Author

No worries, it was my bad, I should learn to read better lol, yea we can probably combine all for sure, I will hopefully have you a more substantial PR soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants