-
Notifications
You must be signed in to change notification settings - Fork 2.7k
migrate from libp2p to iroh #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Evanev7
wants to merge
34
commits into
main
Choose a base branch
from
iroh-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51b7420 to
7af9c25
Compare
ebad10d to
701c99e
Compare
701c99e to
2f4ea86
Compare
2f4ea86 to
e9cfdee
Compare
3 tasks
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Motivation
libp2p is fairly far abstracted from networking hardware. Iroh provides an alternative, and this branch has been my work on a potential future migration. I may revive the attempt at some point, but libp2p is working well at the moment. I think the code quality here is better, as is the lack of the nightly rust toolchain, but it doesn't solve any problems we are facing right now.
Changes
Removed our libp2p dependency, removed our rust-nightly dependency, added an iroh-gossip based exo net implementation.
Why It Works
Test Plan
Minimal - basic functionality is there, but little testing.